setVeryLoud(true);

He / They

Software Developer

  • 0 Posts
  • 7 Comments
Joined 4 years ago
cake
Cake day: April 19th, 2023

help-circle






  • Oh it’s already easy. You start asking the submitter to explain the code. Sometimes it’s just visually obvious, too.

    I’ve always had the opinion of it not being slop if you:

    1. Take ownership and fully understand the code
    2. Make it look like a human wrote it, in other words, scrutinize, re-factor and re-format the code for legibility, performance and maintainability before submitting your patch

    This effectively forces you to do research to properly understand how your patch is implemented and puts you through the mental exercise of cleaning up the code. It also more often than not mostly replaces the code the LLM generated anyway, making it yours.

    I say all this as someone who turns around a lot of PRs at work for being slop. Come back to me when you can take ownership of your git blame.